Skip to content

fix(material/timepicker): deserialize ControlValueAccessor values correctly #30149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix(material/timepicker): deserialize ControlValueAccessor values correctly #30149

merged 1 commit into from
Dec 10, 2024

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 9, 2024

Fixes that the timepicker was clobbering otherwise parseable values when they're assigned through the ControlValueAccessor.

Fixes #30140.

@crisbeto
fix(material/timepicker): deserialize ControlValueAccessor values cor…
f844ed1 
…rectly

Fixes that the timepicker was clobbering otherwise parseable values when they're assigned through the `ControlValueAccessor`.

Fixes angular#30140.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Dec 9, 2024
@crisbeto crisbeto requested a review from a team as a code owner December 9, 2024 09:50
@crisbeto crisbeto requested review from andrewseguin and mmalerba and removed request for a team December 9, 2024 09:50
@crisbeto crisbeto mentioned this pull request Dec 9, 2024
Closed
1 task
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Dec 10, 2024
@crisbeto crisbeto removed the request for review from mmalerba December 10, 2024 20:33
@crisbeto crisbeto merged commit f7d787b into angular:main Dec 10, 2024
25 of 26 checks passed
crisbeto added a commit that referenced this pull request Dec 10, 2024
@crisbeto
fix(material/timepicker): deserialize ControlValueAccessor values cor…
600a8b0 
…rectly (#30149)

Fixes that the timepicker was clobbering otherwise parseable values when they're assigned through the `ControlValueAccessor`.

Fixes #30140.

(cherry picked from commit f7d787b)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: material/timepicker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(Timepicker): Luxon provider does not display date if it exists

2 participants

@crisbeto @andrewseguin