refactor(multiple): use renderer for manually-bound events with options #30195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the repo to Angular 19.1.0-next.3 since it includes some changes to the renderer that we need.
crisbeto
added
target: minor
angular-robot
bot
added
the
area: build & ci
…ndings Adds a utility that we can use to bind events with options in a backwards-compatible way. It will be removed once we get to v20.
crisbeto
force-pushed
the
remaining-event-handlers
branch
from
a19baa1 to
eda992d
Compare
crisbeto
requested review from
amysorto,
andrewseguin and
wagnermaciel
and removed request for
a team
crisbeto
force-pushed
the
remaining-event-handlers
branch
from
eda992d to
b749a8b
Compare
Switches all manually-bound event handlers that were passing options to go through the renderer.
crisbeto
force-pushed
the
remaining-event-handlers
branch
from
b749a8b to
c92253d
Compare
andrewseguin
approved these changes
Dec 17, 2024
|
|
||
| // Event options in `listen` are only supported in 19.1 and beyond. | ||
| // We also allow 0.0.x, because that indicates a build at HEAD. | ||
| if (major > 19 || (major === 19 && minor > 0) || (major === 0 && minor === 0)) { |
There was a problem hiding this comment.
seems like major >= 19 || (major === 0 && minor === 0) should be sufficient?
There was a problem hiding this comment.
19.0.x doesn't have support for the config object in the renderer, only 19.1 and above.
There was a problem hiding this comment.
oh gotcha, I misread minor > 0 as minor >= 0
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jan 6, 2025
This is a second attempt at landing the changes from angular#30195. I've removed some of the riskier changes. Switches all manually-bound event handlers that were passing options to go through the renderer.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches all manually-bound event handlers that were passing options to go through the renderer.