refactor(multiple): replace fromEvent usages #30201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces all of our usages of the rxjs `fromEvent` with direct event listeners going through the renderer. This has a few benefits: * In most cases it made our simpler and easier to follow. * By going through the renderer, other tooling can hook into it (e.g. the tracing service). * It reduces our reliance on rxjs. I also ended up cleaning up the fragile testing setup in `cdk/menu` which would've broken any time we introduce a new `inject` call.
crisbeto
force-pushed
the
from-event-handlers
branch
from
f735823 to
bbf2c5b
Compare
crisbeto
requested review from
amysorto and
andrewseguin
and removed request for
a team
andrewseguin
approved these changes
Dec 18, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces all of our usages of the rxjs
fromEventwith direct event listeners going through the renderer. This has a few benefits:I also ended up cleaning up the fragile testing setup in
cdk/menuwhich would've broken any time we introduce a newinjectcall.