Skip to content

Conversation

@robertIsaac
Copy link
Contributor

improvements:

  • use signal instead of manually detect changes
  • add access modifier to the class properties
  • add missing import of routerLink
  • replace deprecated add/removeListener with add/removeEventListener

@robertIsaac robertIsaac requested a review from a team as a code owner December 22, 2024 22:39
@robertIsaac robertIsaac requested review from andrewseguin and crisbeto and removed request for a team December 22, 2024 22:39
@angular-robot angular-robot bot added area: docs Related to the documentation area: material/sidenav labels Dec 22, 2024
improvements:
- use signal instead of manually detect changes
- add access modifier to the class properties
- add missing import of routerLink
- replace deprecated add/removeListener with add/removeEventListener
@robertIsaac robertIsaac force-pushed the docs/material-sidenav branch from 2ef479e to b488431 Compare December 22, 2024 22:51
@crisbeto crisbeto removed the request for review from andrewseguin December 23, 2024 07:54
@crisbeto crisbeto added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Dec 23, 2024
@crisbeto crisbeto merged commit f04596e into angular:main Dec 23, 2024
9 of 11 checks passed
crisbeto pushed a commit that referenced this pull request Dec 23, 2024
improvements:
- use signal instead of manually detect changes
- add access modifier to the class properties
- add missing import of routerLink
- replace deprecated add/removeListener with add/removeEventListener

(cherry picked from commit f04596e)
@robertIsaac robertIsaac deleted the docs/material-sidenav branch December 23, 2024 11:28
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation area: material/sidenav target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants