fix(material/select): switch away from animations module #30363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verlay directive Adds methods on the `CdkConnectedOverlay` to allow for manual attachment/detachment, instead of going through change detection.
Reworks the select so it doesn't depend on the animations module.
crisbeto
added
target: minor
crisbeto
requested review from
andrewseguin and
wagnermaciel
and removed request for
a team
crisbeto
force-pushed
the
select-no-animations
branch
from
334fc91 to
e09370d
Compare
crisbeto
force-pushed
the
select-no-animations
branch
from
e09370d to
93097f6
Compare
andrewseguin
approved these changes
Jan 23, 2025
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jan 28, 2025
Fixes a regression after angular#30363 where the select panel throws an error if `open` and `close` are called before Angular has had a chance to resolve the `panel`.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jan 28, 2025
Fixes a regression after angular#30363 where the select panel throws an error if `open` and `close` are called before Angular has had a chance to resolve the `panel`.
crisbeto
added a commit
that referenced
this pull request
Jan 28, 2025
) Fixes a regression after #30363 where the select panel throws an error if `open` and `close` are called before Angular has had a chance to resolve the `panel`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the select so it doesn't depend on the animations module.