Skip to content

fix(material/button): increase touch target for icon buttons #30380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix(material/button): increase touch target for icon buttons #30380

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4051dd0
fix(material/button): increase touch target for icon buttons
essjay05 Jan 23, 2025
de569d8
refactor(material/button): change target and remove redundant styles
essjay05 Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/material/button/icon-button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,11 @@
border-radius: 50%;
}

.mat-mdc-button-touch-target {
display: block;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is controlled through the touch-target-display token. The problem we had was that in some densities the buttons become too small and the touch targets overlap when icon buttons are next to each other. It might be better to tackle this through documentation than to increase the touch target.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @crisbeto! Noted! Thanks for the explanation. It looks like in the dev-app demo is where specifically that touch-target-display token seems to be applying the display: none and that in the actual XAP gallery that the touch target is already 48x48 and clickable outside the visual grey icon button. I'm closing this as WAI.

opacity: 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This element is already transparent so I'm not sure what the opacity is doing here.

}

// MDC used to include this and it seems like a lot of apps depend on it.
&[hidden] {
display: none;
Expand All @@ -92,4 +97,5 @@
opacity: 1;
}
}

}
Loading