Skip to content

Conversation

crisbeto
Copy link
Member

Adds a packageGroup to the package.json of the CDK to avoid some warnings during ng update.

Fixes #30464.

Adds a `packageGroup` to the `package.json` of the CDK to avoid some warnings during `ng update`.

Fixes angular#30464.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Feb 11, 2025
@crisbeto crisbeto requested a review from a team as a code owner February 11, 2025 08:04
@crisbeto crisbeto requested review from a team, andrewseguin, devversion and mmalerba and removed request for a team February 11, 2025 08:04
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Feb 11, 2025
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means ng update @angular/cdk will update Material too. Is this intended?

@crisbeto
Copy link
Member Author

Yeah I think we'd want that in general given that we require the exact same version of CDK as Material in the peerDependencies.

@devversion
Copy link
Member

Sounds good. I think the previous behavior is more correct, but this is also reasonable and probably more "convenient".

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Feb 11, 2025
@crisbeto crisbeto removed request for a team, andrewseguin and mmalerba February 11, 2025 11:41
@crisbeto crisbeto merged commit 4c3206c into angular:main Feb 11, 2025
25 checks passed
@crisbeto
Copy link
Member Author

The changes were merged into the following branches: main, 19.1.x

crisbeto added a commit that referenced this pull request Feb 11, 2025
Adds a `packageGroup` to the `package.json` of the CDK to avoid some warnings during `ng update`.

Fixes #30464.

(cherry picked from commit 4c3206c)
@rubiesonthesky
Copy link

I think this has unwanted consequences: angular/angular-cli#29627

@crisbeto
Copy link
Member Author

This was a recommendation from Tooling: #30464 (comment)

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When Upgrading from version A to B, there is always an incompatible peer dependencies issue between CDK and CLI

3 participants