-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: add packageGroup to CDK #30468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds a `packageGroup` to the `package.json` of the CDK to avoid some warnings during `ng update`. Fixes angular#30464.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means ng update @angular/cdk
will update Material too. Is this intended?
Yeah I think we'd want that in general given that we require the exact same version of CDK as Material in the |
Sounds good. I think the previous behavior is more correct, but this is also reasonable and probably more "convenient". |
The changes were merged into the following branches: main, 19.1.x |
I think this has unwanted consequences: angular/angular-cli#29627 |
This was a recommendation from Tooling: #30464 (comment) |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds a
packageGroup
to thepackage.json
of the CDK to avoid some warnings duringng update
.Fixes #30464.