fix(material/timepicker): allow scroll strategy to be customized #30479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ular#30473) Adds an injection token to the timepicker that allows the scroll strategy to be customized, similar to other components. Fixes angular#30421.
crisbeto
added
action: merge
crisbeto
requested review from
andrewseguin and
mmalerba
and removed request for
a team
andrewseguin
approved these changes
Feb 12, 2025
mmalerba
reviewed
Feb 12, 2025
| export const MAT_TIMEPICKER_CONFIG: InjectionToken<MatTimepickerConfig>; | ||
|
|
||
| // @public | ||
| export const MAT_TIMEPICKER_SCROLL_STRATEGY: InjectionToken<() => ScrollStrategy>; |
There was a problem hiding this comment.
is there a reason to not just put it as part of the MAT_TIMEPICKER_CONFIG?
There was a problem hiding this comment.
Mostly consistency with the rest of the components.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is a cherry-pick of #30473.
Adds an injection token to the timepicker that allows the scroll strategy to be customized, similar to other components.
Fixes #30421.