Docs site cleanups #30488
Merged
Docs site cleanups #30488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the docs site to the latest version of Angular.
The docs site was loading the data of all the examples up-front through an eager import which was bringing in ~170kb of JavaScript which isn't necessary for the initial load. These changes refactor the various call sites so that they load the example data asynchronously.
crisbeto
added
target: patch
angular-robot
bot
added
the
area: build & ci
Drops the `@angular/animations` module from the docs site since it's no longer necessary. This removes another ~70kb from the initial bundle.
Removes (almost) all of our `@NgModule` usage in the docs site by replacing their usages with standalone imports.
Runs the inject migration over the docs site to make it consistent with the rest of the repo.
Reworks the docs site to remove all remaining `@NgModule` usages.
crisbeto
force-pushed
the
docs-bundle-size
branch
from
01170fa to
8d329bb
Compare
Fixes that the formatting check was catching some files incorrectly, like pnpm lock file.
crisbeto
commented
Feb 13, 2025
|
|
||
| bootstrapApplication(MaterialDocsApp, { | ||
| providers: [ | ||
| prefersReducedMotion ? provideNoopAnimations() : provideAnimations(), |
There was a problem hiding this comment.
My plan is to handle reduced motion centrally from Material, instead of relying on the animations module for it.
crisbeto
requested review from
andrewseguin,
mmalerba and
wagnermaciel
and removed request for
a team
crisbeto
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a bunch of cleanups for the docs site (see below) that ended up removing 230kb from the initial bundle.
build: update the docs site to latest Angular
Updates the docs site to the latest version of Angular.
fix(material-angular-io): remove docs data from critical path
The docs site was loading the data of all the examples up-front through an eager import which was bringing in ~170kb of JavaScript which isn't necessary for the initial load. These changes refactor the various call sites so that they load the example data asynchronously.
fix(material-angular-io): remove animations dependency
Drops the
@angular/animationsmodule from the docs site since it's no longer necessary. This removes another ~70kb from the initial bundle.refactor(material-angular-io): use standalone imports instead of modules
Removes (almost) all of our
@NgModuleusage in the docs site by replacing their usages with standalone imports.refactor(material-angular-io): switch to inject function
Runs the inject migration over the docs site to make it consistent with the rest of the repo.
refactor(material-angular-io): remove remaining modules
Reworks the docs site to remove all remaining
@NgModuleusages.build: narrow down prettier file set
Fixes that the formatting check was catching some files incorrectly, like pnpm lock file.