Skip to content

fix(material/tooltip): regression when injecting ViewContainerRef #30500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2025
Merged

fix(material/tooltip): regression when injecting ViewContainerRef #30500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/material/tooltip/tooltip.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ export class MatTooltip implements OnDestroy, AfterViewInit {
private _focusMonitor = inject(FocusMonitor);
protected _dir = inject(Directionality);
private _injector = inject(Injector);
private _viewContainerRef = inject(ViewContainerRef);
private _defaultOptions = inject<MatTooltipDefaultOptions>(MAT_TOOLTIP_DEFAULT_OPTIONS, {
optional: true,
});
Expand Down Expand Up @@ -455,8 +456,7 @@ export class MatTooltip implements OnDestroy, AfterViewInit {
const overlayRef = this._createOverlay(origin);
this._detach();
this._portal =
this._portal ||
new ComponentPortal(this._tooltipComponent, this._injector.get(ViewContainerRef));
this._portal || new ComponentPortal(this._tooltipComponent, this._viewContainerRef);
const instance = (this._tooltipInstance = overlayRef.attach(this._portal).instance);
instance._triggerElement = this._elementRef.nativeElement;
instance._mouseLeaveHideDelay = this._hideDelay;
Expand Down
Loading