Skip to content

fix(cdk/drag-drop): incorrect type DragConstrainPosition #30510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 21, 2025
Merged

fix(cdk/drag-drop): incorrect type DragConstrainPosition #30510

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0abfecd
fix(cdk/drag-drop): incorrect type DragConstrainPosition
Veribelll Feb 18, 2025
e2938a0
fix(cdk/drag-drop): change type in CdkDrag for input cdkDragConstrain…
Veribelll Feb 18, 2025
8c107b9
fix(cdk/drag-drop): change type in CdkRef for property constrainPosition
Veribelll Feb 18, 2025
ad26f10
fix(cdk/drag-drop): move type DragConstrainPosition in DragRef
Veribelll Feb 18, 2025
60e8617
fix(cdk/drag-drop): added type DragConstrainPosition in public api
Veribelll Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/cdk/drag-drop/directives/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,12 @@ export type DragStartDelay = number | {touch: number; mouse: number};
export type DragAxis = 'x' | 'y';

/** Function that can be used to constrain the position of a dragged element. */
export type DragConstrainPosition = (point: Point, dragRef: DragRef) => Point;
export type DragConstrainPosition = (
userPointerPosition: Point,
dragRef: DragRef,
dimensions: DOMRect,
pickupPositionInElement: Point,
) => Point;

/** Possible orientations for a drop list. */
export type DropListOrientation = 'horizontal' | 'vertical' | 'mixed';
Expand Down
2 changes: 1 addition & 1 deletion tools/public_api_guard/cdk/drag-drop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ export function copyArrayItem<T = any>(currentArray: T[], targetArray: T[], curr
export type DragAxis = 'x' | 'y';

// @public
export type DragConstrainPosition = (point: Point, dragRef: DragRef) => Point;
export type DragConstrainPosition = (userPointerPosition: Point, dragRef: DragRef, dimensions: DOMRect, pickupPositionInElement: Point) => Point;

// @public
export class DragDrop {
Expand Down
Loading