Skip to content

fix(material/select): added ecs click handling in host keydown #30520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(material/select): added ecs click handling in host keydown #30520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/material/select/select.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1033,6 +1033,10 @@ export class MatSelect
hasDeselectedOptions ? option.select() : option.deselect();
}
});
} else if (event.keyCode === ESCAPE && !hasModifierKey(event)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this would fix the issue at the moment, we have a TODO to move all of this logic into _handleOverlayKeydown for better interop with the rest of the overlays. Once that happens the sidenav use case will break again so I'm not sure we should land the change just to have it regress later.

event.stopPropagation();
event.preventDefault();
this.close();
} else {
const previouslyFocusedIndex = manager.activeItemIndex;

Expand Down
Loading