Skip to content

[19.2.x] build: update @angular/bazel to support .d.ts code splitting #30618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2025
Merged

[19.2.x] build: update @angular/bazel to support .d.ts code splitting #30618

merged 1 commit into from
Mar 12, 2025

Conversation

devversion
Copy link
Member

This will unblock the fixit where we'll introduce relative imports that currently (without this commit) result in duplicated d.ts declarations between entry-points.

@devversion devversion changed the title build: update @angular/bazel to support .d.ts code splitting [19.2.x] build: update @angular/bazel to support .d.ts code splitting Mar 11, 2025
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Mar 11, 2025
@devversion
build: update @angular/bazel to support .d.ts code splitting
a90d6d4 
This will unblock the fixit where we'll introduce relative imports
that currently (without this commit) result in duplicated `d.ts`
declarations between entry-points.
@devversion devversion added the target: patch This PR is targeted for the next patch release label Mar 11, 2025
@devversion devversion marked this pull request as ready for review March 11, 2025 21:34
@devversion devversion requested review from a team as code owners March 11, 2025 21:34
@devversion devversion requested review from crisbeto and removed request for a team March 11, 2025 21:34
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Mar 11, 2025
josephperrott
josephperrott approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion merged commit 596a85f into angular:19.2.x Mar 12, 2025
24 of 25 checks passed
@devversion devversion deleted the code-splitting-dts branch March 12, 2025 07:36
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@josephperrott josephperrott josephperrott approved these changes

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devversion @crisbeto @josephperrott @andrewseguin