Skip to content

build: remove unused madge and material.angular.io image optimization #30674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

build: remove unused madge and material.angular.io image optimization #30674

merged 1 commit into from
Mar 21, 2025

Conversation

@josephperrott
Copy link
Member

Remove the unused madge dependency and the image optimization scripts for material.angular.io along with its no longer used dependencies

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release area: build & ci Related the build and CI infrastructure of the project labels Mar 20, 2025
@josephperrott josephperrott requested a review from a team as a code owner March 20, 2025 18:50
@josephperrott josephperrott requested review from andrewseguin and mmalerba and removed request for a team March 20, 2025 18:50
@josephperrott josephperrott added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Mar 20, 2025
devversion
devversion approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as I don't want to block; but might be worth pinging #components about the screenshot scenes thing. The e2e code is also still there?

@josephperrott
build: remove unused madge and material.angular.io image optimization
d78f252 
Remove the unused madge dependency and the image optimization scripts for material.angular.io along with its no longer used dependencies
@josephperrott josephperrott merged commit b53de49 into angular:main Mar 21, 2025
24 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@josephperrott @devversion