Skip to content

Conversation

@andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented Mar 20, 2025

BREAKING CHANGE:

  • Theming CSS variables prefixed with --mdc- are now prefixed with --mat-. Stylesheets that directly define these variables should be automatically renamed with the update schematic. To avoid future breaking changes as variables may be renamed or removed, use the overrides API which will provide a safer abstraction along with token-name checks.

@andrewseguin andrewseguin added the target: major This PR is targeted for the next major release label Mar 20, 2025
@andrewseguin andrewseguin requested a review from a team as a code owner March 20, 2025 23:00
@andrewseguin andrewseguin requested review from crisbeto, mmalerba and wagnermaciel and removed request for a team March 20, 2025 23:00
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to ship with a schematic?

Edit: Nevermind, just read the description. LGTM!

@andrewseguin
Copy link
Contributor Author

Yeah just a simple find-and-replace for --mdc with --mat

Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't result in any name collisions? I'm pleasantly surprised

@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Mar 27, 2025
@andrewseguin andrewseguin merged commit ad6a21e into angular:main Mar 27, 2025
23 of 25 checks passed
mistrykaran91 pushed a commit to mistrykaran91/components that referenced this pull request Apr 7, 2025
* refactor: rename mdc- prefixed tokens to mat-

* refactor: repeat mdc tokens along with mat rename

* refactor: include mdc prefix in icon button

---------

Co-authored-by: Andrew Seguin <[email protected]>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants