Third iteration of rules_js migration
#30697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
area: build & ci
devversion
added
target: patch
crisbeto
approved these changes
Mar 24, 2025
devversion
force-pushed
the
rjs-3
branch
2 times, most recently
from
6377b0e to
0491957
Compare
Migrates the theming tests to `rules_js`. This also requires us to bring in the Jasmine ruleset, and fix some issues with the test tsconfig.
This commit migrates more targets from `ts_library` to `ts_project`.
This will allow pnpm to identifiy dependencies like `parse5` to be understood as non-dev dependencies, so that they are propagated with `rules_js` even when `cdk` is linked as `npm_package`. This is necessary when using the npm package of CDK in the Material schematic tests. To do this we need to give up on our non-statically readable substitutions for tslib and RxJS but this is acceptable as those don't change often and the benefits of the pnpm workspace are more important. We move `parse5` from `optionalDependencies` to `dependencies` so that pnpm recognizes this as non-dev dependency for the runtime execution of the CDK package. `parse5` doesn't have any native code, so `optionalDependencies` vs `dependencies` doesn't make a difference. Long-term we should consider simply bundling `parse5` here.
Migrates all schematics code to `ts_project` and simplifies complexity/confusion around devmode,prodmode ESM and CommonJS.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits