Skip to content

fix(cdk/overlay): use MutationObserver to detach overlay #30703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2025
Merged

fix(cdk/overlay): use MutationObserver to detach overlay #30703

merged 1 commit into from
Mar 27, 2025

Conversation

@mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba force-pushed the overlay-ar branch 3 times, most recently from 96897f8 to 4b228ab Compare March 26, 2025 21:44
@mmalerba mmalerba marked this pull request as ready for review March 26, 2025 21:44
@mmalerba mmalerba requested review from a team as code owners March 26, 2025 21:44
@mmalerba mmalerba requested review from andrewseguin, crisbeto and pkozlowski-opensource and removed request for a team March 26, 2025 21:44
@mmalerba mmalerba changed the title WIP: attempt to use MutationObserver to detach overlay fix(cdk/overlay): use MutationObserver to detach overlay Mar 26, 2025
@mmalerba mmalerba added the target: major This PR is targeted for the next major release label Mar 26, 2025
@devversion devversion removed the request for review from a team March 27, 2025 11:27
crisbeto
crisbeto reviewed Mar 27, 2025
View reviewed changes
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Mar 27, 2025
@mmalerba mmalerba merged commit f9973ee into angular:main Mar 27, 2025
20 of 22 checks passed
mistrykaran91 pushed a commit to mistrykaran91/components that referenced this pull request Apr 7, 2025
@mmalerba @mistrykaran91
fix(cdk/overlay): use MutationObserver to detach overlay (angular#30703)
581e1c3
mmalerba added a commit to mmalerba/components that referenced this pull request Apr 22, 2025
@mmalerba
test: add back fixture.whenStable for patch branch
a089609 
angular#30878 cleaned up usages of
`whenStable` that were no longer needed. However, the change that makes
them unneeded (angular#30703) is not
on the patch branch, so this PR reverts the tests to their original
form on the patch branch.
@mmalerba mmalerba mentioned this pull request Apr 22, 2025
Merged
mmalerba added a commit that referenced this pull request Apr 22, 2025
@mmalerba
test: add back fixture.whenStable for patch branch (#30923)
bf0800c 
#30878 cleaned up usages of
`whenStable` that were no longer needed. However, the change that makes
them unneeded (#30703) is not
on the patch branch, so this PR reverts the tests to their original
form on the patch branch.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: cdk/overlay target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmalerba @crisbeto