[19.2.x]: Fourth iteration of ts_library migration
#30714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ts_project` interop currently conflicts with some mappings from e.g. `ts_library`. This can happen when the same target is transitively referenced via the interop, or directly in e.g. `ng_module` still.
Migrates all `ng_test_library` targets to `ts_project`.
The new version contains some changes to support `--traceResolution`, which is useful for debugging.
The `rules_js` `npm_package` rule does not support nested NPM packages, so we should stop doing that and instead use an idiomatic filegroup.
Migrates all `ng_e2e_test_library` targets to use `ts_project` directly. This is simpler and more obvious.
This rule is no longer needed, so we can remove it from our macros. Also removes patches for it.
angular-robot
bot
added
the
area: build & ci
crisbeto
approved these changes
Mar 26, 2025
devversion
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch port of #30710 and #30704