refactor(cdk-experimental/ui-patterns): track list selection by value #30733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wagnermaciel
commented
Mar 27, 2025
wagnermaciel
commented
- Switch to using values instead of ids for tracking selected items in a list
* Switch to using values instead of ids for tracking selected items in a list
wagnermaciel
requested review from
crisbeto and
mmalerba
and removed request for
a team
mmalerba
reviewed
Mar 27, 2025
src/cdk-experimental/ui-patterns/behaviors/list-focus/list-focus.ts
Outdated
Show resolved
Hide resolved
src/cdk-experimental/ui-patterns/behaviors/list-selection/list-selection.spec.ts
Show resolved
Hide resolved
mmalerba
approved these changes
Mar 28, 2025
wagnermaciel
added
action: merge
szoboszlaypali
pushed a commit
to szoboszlaypali/components
that referenced
this pull request
Apr 1, 2025
…angular#30733) * refactor(cdk-experimental/ui-patterns): track list selection by value * Switch to using values instead of ids for tracking selected items in a list * fixup! refactor(cdk-experimental/ui-patterns): track list selection by value * fixup! refactor(cdk-experimental/ui-patterns): track list selection by value * fixup! refactor(cdk-experimental/ui-patterns): track list selection by value
mistrykaran91
pushed a commit
to mistrykaran91/components
that referenced
this pull request
Apr 7, 2025
…angular#30733) * refactor(cdk-experimental/ui-patterns): track list selection by value * Switch to using values instead of ids for tracking selected items in a list * fixup! refactor(cdk-experimental/ui-patterns): track list selection by value * fixup! refactor(cdk-experimental/ui-patterns): track list selection by value * fixup! refactor(cdk-experimental/ui-patterns): track list selection by value
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.