[19.2.x]: Migrate ng_module #30740
Merged
[19.2.x]: Migrate ng_module #30740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets up the new `ng_project` rule and uses it in `cdk/a11y`. Also sets up this rule similar to our `ts_project` interop- reusing that code completely, yay!
With the new `ts_project`, or `ng_project` rule, HTML templates of components are also copied over to the bazel bin. This unveiled a naming conflict of e.g. `slider.md` being generated as `slider.html`; while there is a template like `slider.html`.
This commit migrates all `ng_module` targets to the new `ng_project` rule. This change was partially assisted/generated using Gemini.
Currently we always use our build tsconfigs from `/src`, whenever we see a `ts_project`, or `ng_project` target. This doesn't work for targets outside of `src` and ambiguously breaks the build. This commit makes this a more obvious failure mode.
We've decided that this size testing infra is not useful after the MDC migration and can be removed; we can easily re-add if we want. Notably it was disabled/not running on CI (in a blocking mode) for months.
Temporarily patches the legacy `ng_package` rule to properly request partial compilation output from the new `ng_project` rule targets.
This commit removes references to the `ng_module` rule.
We still use an older version of Angular core here. We recently switched to a whole new bundling approach for APF that fixes this long-term issue; and going forward `ngDevMode` types are included. In the main branch we already benefit from this, and don't need the patch.
angular-robot
bot
added
the
area: build & ci
devversion
requested review from
andrewseguin,
mmalerba and
wagnermaciel
and removed request for
a team
devversion
added
target: patch
andrewseguin
approved these changes
Mar 28, 2025
devversion
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch port of #30731