fix(material/tabs): allow ID to be set on tab #30768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a long-standing issue where users weren't able to assign an ID to a tab. Fixes angular#4136.
crisbeto
requested review from
mmalerba and
wagnermaciel
and removed request for
a team
andrewseguin
approved these changes
Apr 2, 2025
eneajaho
reviewed
Apr 2, 2025
| * Custom ID for the tab, overriding the auto-generated one by Material. | ||
| * Note that when using this input, it's your responsibility to ensure that the ID is unique. | ||
| */ | ||
| @Input() id: string | null = null; |
There was a problem hiding this comment.
Since this is a new input, and no one is currently depending on it, wouldn't it be better if it was a signal input?
|
The changes were merged into the following branches: main, 19.2.x |
crisbeto
added a commit
that referenced
this pull request
Apr 2, 2025
mistrykaran91
pushed a commit
to mistrykaran91/components
that referenced
this pull request
Apr 7, 2025
Fixes a long-standing issue where users weren't able to assign an ID to a tab. Fixes angular#4136.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a long-standing issue where users weren't able to assign an ID to a tab.
Fixes #4136.