[19.2.x]: Stop relying on linker for tests #30788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate all `nodejs_binary` targets to `rules_js`.
Migrates `nodejs_test` targets to `rules_js`.
In order to be able to pnpm-link first-party packages that are using `ng_package`, we technically already need our new `ng_package` rule. That rule is still WIP, so this interop layer allows for the same with the old `ng_package` rule
Sets up the pnpm workspace for first party packages, so that we can use those for cross-package references; or real integration testing.
Updates integration tests to work with the linked first-party packages.
angular-robot
bot
added
the
area: build & ci
devversion
force-pushed
the
patch-rjs-8
branch
2 times, most recently
from
56dfd32 to
c8b7e80
Compare
Instead of e.g. depending on `src/cdk/testing`, we should use the first-party linked package so that npm-module imports like `@angular/cdk` still work. This is the new approach for `rules_js`. It's notably slower, but with the simplicity gained, it's an acceptable trade-off we are taking.
Introduces a new spec-bundle Karma variant that works with `rules_js`, and updates the interop to work with `rules_js` node modules.
Fixes that some remaining imports weren't updated to be relative.
…eer dep This is necessary until a new version of the animations package is published. See: angular/angular#60660
Modernizes the rule to not rely on `rules_webtesting`. Yay.
This likely is an artifact of the size tests recently removed.
Right now `.d.ts` could incorrectly contain references to shared chunk `.d.ts`. This is addressed by properly using the `bundler` module resolution— which instructs TS to respect `exports`.
The rule was replaced with our `rjs` variant.
The old `devmode` rule isn't necessary anymore and doesn't work with the real node module directories.
We now link via `postinstall` lifecycle hooks, so we don't need this anymore.
This is already fixed in `@angular/core@20` but we need to patch it here for our local development.
The JS file is ESM, but Node doesn't recognize this because there is no explicit extension or `package.json` with `type: module`.
devversion
added
target: patch
crisbeto
approved these changes
Apr 3, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch port #30758