Skip to content

build: clean-up to use fine-grained targets for faster rebuilds #30797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 4, 2025
Merged

build: clean-up to use fine-grained targets for faster rebuilds #30797

merged 3 commits into from
Apr 4, 2025

Conversation

devversion
Copy link
Member

  • see individual commits

@devversion
build: cleanup more usages of @npm// repository
34602d1 
Cleans up usages of the old `@npm` repository, so that we can quickly remove this.
@devversion
Revert "build: migrate all cross-package targets to use first-party l…
e0dcecd 
…inks"

This reverts commit bca1ac9.
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Apr 4, 2025
@devversion
build: clean-up to use fine-grained targets for faster rebuilds
e9a3b11 
We've decided to not leverage pnpm workspace first-party dependency
linking, except for integration tests.

This commit cleans up leftovers from the previous revert commit, and
also fixes other tests to work with the fine-grained targets. In
addition, we also improve visibility rules to safe-guard against
accidentally relying on the pnpm first party linkings.
@devversion devversion requested a review from crisbeto April 4, 2025 11:34
@devversion devversion marked this pull request as ready for review April 4, 2025 11:34
@devversion devversion requested review from a team as code owners April 4, 2025 11:34
@devversion devversion requested review from mmalerba and removed request for a team April 4, 2025 11:34
@devversion devversion added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 4, 2025
@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 4, 2025
@devversion devversion merged commit 207bc6c into angular:main Apr 4, 2025
31 of 35 checks passed
@devversion devversion deleted the rjs-10-exp branch April 4, 2025 11:47
@devversion devversion mentioned this pull request Apr 4, 2025
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba mmalerba is a code owner automatically assigned from angular/components-googlers

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@devversion @crisbeto