Skip to content

[19.2.x]: build: switch karma tests to rules_browsers #30832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2025
Merged

[19.2.x]: build: switch karma tests to rules_browsers #30832

merged 2 commits into from
Apr 9, 2025

Conversation

devversion
Copy link
Member

Patch port of #30820

@devversion
build: switch karma tests to rules_browsers
2d4861f 
Switches Karma tests to our new browser testing ruleset, that is using
much more recent browser versions, and a more up-to-date future-proof
test runner called `@web/test-runner`; that is also one of the options
for Angular CLI.

Also updates the browsers because now we are using Puppeteer, yay! this
should allow us to stay up-to-date much easier!
@devversion
build: speed up legacy tests bundle
0908550 
I've noticed a speed up from 4min to like 30seconds that way.
Sass also recommends the sync variant.
@devversion devversion changed the base branch from main to 19.2.x April 9, 2025 16:42
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Apr 9, 2025
@devversion devversion added the target: patch This PR is targeted for the next patch release label Apr 9, 2025
@devversion devversion marked this pull request as ready for review April 9, 2025 17:07
@devversion devversion requested review from a team as code owners April 9, 2025 17:07
@devversion devversion requested review from crisbeto and mmalerba and removed request for a team April 9, 2025 17:07
@devversion devversion closed this Apr 9, 2025
@devversion devversion reopened this Apr 9, 2025
@devversion
Copy link
Member Author

(re-triggering CI)

@devversion devversion merged commit 8d29696 into angular:19.2.x Apr 9, 2025
26 of 28 checks passed
@devversion devversion deleted the patch-wtr branch April 9, 2025 17:54
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto Awaiting requested review from crisbeto crisbeto is a code owner automatically assigned from angular/components-googlers

@mmalerba mmalerba Awaiting requested review from mmalerba mmalerba is a code owner automatically assigned from angular/components-googlers

Assignees

No one assigned

Labels

area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@devversion