fix(material/form-field): add hasFloatingLabel input and update classes if mat-label is added and removed dynamically
#30849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistrykaran91
requested review from
crisbeto and
andrewseguin
and removed request for
a team
mistrykaran91
force-pushed
the
fix/floating-label-hide-show-issue
branch
3 times, most recently
from
b425115 to
ad897c4
Compare
mistrykaran91
force-pushed
the
fix/floating-label-hide-show-issue
branch
from
ad897c4 to
cbcb5fd
Compare
mistrykaran91
force-pushed
the
fix/floating-label-hide-show-issue
branch
3 times, most recently
from
81b10c4 to
cd6db00
Compare
mistrykaran91
force-pushed
the
fix/floating-label-hide-show-issue
branch
from
cd6db00 to
632f238
Compare
mistrykaran91
force-pushed
the
fix/floating-label-hide-show-issue
branch
2 times, most recently
from
a57d904 to
e62a267
Compare
…es if mat-label is added and removed dynamically Currently, when `mat-Label` is added dynamically initially its not visible in DOM, this fix will add/remove classes for the same. Fixes angular#29939
mistrykaran91
force-pushed
the
fix/floating-label-hide-show-issue
branch
from
e62a267 to
fc30954
Compare
|
@crisbeto @andrewseguin: It will be helpful if this can be looked into :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when
mat-Labelis added dynamically initially its not visible in DOM, this fix will add/remove classes for the same.Fixes #29939