-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Migrate integration tests #30853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Migrate integration tests #30853
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
0f8673d
build: replace server_test rule with shared one from `rules_browsers`
devversion de1639c
build: remove more unused rules
devversion 4ea7771
build: switch integration tests to pnpm and use `rules_js`-based rule
devversion 5606aac
build: remove remaining `@npm//` usages
devversion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,36 +1,16 @@ | ||
load("@bazel_skylib//lib:dicts.bzl", "dicts") | ||
load("//tools:integration.bzl", "CLI_PROJECT_MAPPINGS") | ||
load("//tools:defaults.bzl", "node_integration_test") | ||
load("//tools:integration.bzl", "LOCAL_NPM_PACKAGES", "integration_test") | ||
|
||
npmPackageMappings = dicts.add( | ||
dicts.omit( | ||
CLI_PROJECT_MAPPINGS, | ||
# Exclude rxjs, because we want to use the version from the package.json. | ||
# Version 6.x that the rest of the project uses has some packaging issues. See: | ||
# https://github.com/angular/components/pull/25241#issuecomment-1178701633 | ||
["@npm//:rxjs_archive"], | ||
), | ||
{ | ||
"//src/cdk:npm_package_archive": "@angular/cdk", | ||
"//src/material:npm_package_archive": "@angular/material", | ||
}, | ||
) | ||
|
||
node_integration_test( | ||
integration_test( | ||
name = "test", | ||
srcs = glob(["**/*"]), | ||
commands = [ | ||
# Note: We use a cache folder within the integration test as otherwise | ||
# the NPM package mapped archive would be cached in the system. | ||
# See: https://github.com/yarnpkg/yarn/issues/2165. | ||
# TODO(devversion): determine if a solution/workaround could live in the test runner. | ||
"yarn install --cache-folder .yarn_cache_folder/", | ||
"yarn e2e", | ||
"pnpm i", | ||
"pnpm run e2e", | ||
], | ||
npm_packages = npmPackageMappings, | ||
npm_packages = LOCAL_NPM_PACKAGES, | ||
setup_chromium = True, | ||
tags = [ | ||
# This test relies on `yarn` so there needs to be internet access. | ||
# This test relies on `pnpm` so there needs to be internet access. | ||
"requires-network", | ||
], | ||
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.