fix(material/autocomplete): add support for initial value in form control #30861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistrykaran91
requested review from
mmalerba and
wagnermaciel
and removed request for
a team
mistrykaran91
force-pushed
the
fix/highlgiht-value-in-options-with-check-icon
branch
2 times, most recently
from
c47259e to
81b722a
Compare
mistrykaran91
force-pushed
the
fix/highlgiht-value-in-options-with-check-icon
branch
from
81b722a to
1478c8d
Compare
mistrykaran91
force-pushed
the
fix/highlgiht-value-in-options-with-check-icon
branch
from
1478c8d to
bb4452b
Compare
…trol Currently, when we have some initial value in formcontrol those are not marked as selected, this fix will check the initial value and if its matched, will be marked as selected. Fixes angular#29422
mistrykaran91
force-pushed
the
fix/highlgiht-value-in-options-with-check-icon
branch
from
bb4452b to
1a4e9ea
Compare
|
@mmalerba @wagnermaciel: It will be helpful if this can be looked into :) |
mmalerba
approved these changes
Sep 29, 2025
mmalerba
added
action: merge
mmalerba
requested changes
Sep 30, 2025
| ); | ||
| if (selectedOption && !selectedOption.selected) { | ||
| selectedOption.select(false); | ||
| this._changeDetectorRef.detectChanges(); |
There was a problem hiding this comment.
does markForCheck() work here? we generally try to avoid directly calling detectChanges()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when we have some initial value in form control those are not marked as selected, this fix will check the initial value and if its matched, will be marked as selected.
Fixes #29422