Switch Sass compilations to Dart Sass and other cleanups #30875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
area: build & ci
devversion
force-pushed
the
sass-rules
branch
2 times, most recently
from
65756d4 to
37e14cc
Compare
devversion
added
target: patch
devversion
requested review from
crisbeto and
wagnermaciel
and removed request for
a team
devversion
changed the title
devversion
changed the title
alan-agius4
reviewed
Apr 16, 2025
alan-agius4
approved these changes
Apr 16, 2025
This will be much faster, doesn't rely on workers that execute outside of Bazel sandbox and can cause subtle confusion (see recent Sass changes).
This is cleaner and follows the new `tools/bazel/x.bzl` folder pattern.
Styling token extraction was included in docs-content because it was the only way to conveniently expose data to the docs site. Now with the proper monorepo setup, this is much easier and we can stop running this JS-based Sass compilation that is rather slow— in development workflows.
Enables proper source maps in dev-app, and also includes sources in the maps as most people probably don't integrate the source project into dev tools.
We have an integration linker test that verifies the linker better. The tests currently aren't verifying anything.
devversion
added
action: merge
devversion
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits