test(multiple): rework whenStable usages #30878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
adolgachev and
andrewseguin
and removed request for
a team
andrewseguin
approved these changes
Apr 16, 2025
We have some really old tests that were depending on `fixture.whenStable` even though they don't need to. These changes clean them up.
crisbeto
force-pushed
the
when-stable-remove
branch
from
2eb2434 to
9666698
Compare
crisbeto
changed the title
|
The changes were merged into the following branches: main, 19.2.x |
crisbeto
added a commit
that referenced
this pull request
Apr 16, 2025
We have some really old tests that were depending on `fixture.whenStable` even though they don't need to. These changes clean them up. (cherry picked from commit 357cfd3)
mmalerba
added a commit
to mmalerba/components
that referenced
this pull request
Apr 22, 2025
angular#30878 cleaned up usages of `whenStable` that were no longer needed. However, the change that makes them unneeded (angular#30703) is not on the patch branch, so this PR reverts the tests to their original form on the patch branch.
mmalerba
added a commit
that referenced
this pull request
Apr 22, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some really old tests that were depending on
fixture.whenStableeven though they don't need to. These changes clean them up.