[PATCH] Migrate to use rules_js based ng_package #30917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephperrott
added
action: merge
josephperrott
requested review from
adolgachev
and removed request for
a team and
adolgachev
|
@josephperrott I'm not really sure how this test is related to what you changed, but it does seem to be consistently failing for this PR |
|
@mmalerba These failures are already failing on upstream. I was just waiting for them to be corrected and I would rebase so it would go green. |
josephperrott
force-pushed
the
replace-ng-package-patch
branch
from
705181d to
ea76d1e
Compare
|
Oh I see, I didn't realize this was targeting |
mmalerba
approved these changes
Apr 22, 2025
mmalerba
force-pushed
the
replace-ng-package-patch
branch
from
ea76d1e to
f64bfce
Compare
mmalerba
added a commit
to mmalerba/components
that referenced
this pull request
Apr 22, 2025
…)" This reverts commit 89db9f7.
mmalerba
added a commit
that referenced
this pull request
Apr 22, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.