Consolidate linting setup #30975
Merged
Consolidate linting setup #30975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
target: patch
angular-robot
bot
added
the
area: build & ci
Removes the linting from the docs site directory so that we can consolidate it with the rest of the project.
Expands the tslint check to cover the docs site and fixes all of the failures.
Expands style linting to the docs site and resolves all the breakages.
crisbeto
force-pushed
the
consolidate-lint
branch
from
1a574ad to
9935403
Compare
crisbeto
requested review from
andrewseguin,
mmalerba and
wagnermaciel
and removed request for
a team
crisbeto
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the main repo and docs site have two different sets of lint rules which aren't exactly consistent with each other. Furthermore, we didn't have linting enabled for styles in the docs site.
These changes consolidate the lint setup so that the docs site uses the same linting as the rest of the project, and they resolve any failures that showed up as a result.