fix(material/table): height tokens not applying to flex table #30978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes that the flexbox-based table had a hardcoded height for the rows, instead of using the tokens. Fixes angular#30906.
crisbeto
requested review from
adolgachev and
andrewseguin
and removed request for
a team
|
Thanks for the PR. |
andrewseguin
approved these changes
Apr 29, 2025
crisbeto
added
target: patch
|
The changes were merged into the following branches: main, 19.2.x |
crisbeto
added a commit
that referenced
this pull request
Apr 29, 2025
|
There is a regression in your CI/CD now? |
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Apr 29, 2025
angular#30978 was cherry-picked into the patch branch, but it's using APIs that aren't available in v19. These changes resolve the build failure.
Merged
crisbeto
added a commit
that referenced
this pull request
Apr 29, 2025
#30978 was cherry-picked into the patch branch, but it's using APIs that aren't available in v19. These changes resolve the build failure.
wildcardalice
pushed a commit
to wildcardalice/components
that referenced
this pull request
May 12, 2025
…r#30978) Fixes that the flexbox-based table had a hardcoded height for the rows, instead of using the tokens. Fixes angular#30906.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the flexbox-based table had a hardcoded height for the rows, instead of using the tokens.
Fixes #30906.