Skip to content

fix(material/sidenav): fix tabindex issue on side mode #30979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(material/sidenav): fix tabindex issue on side mode #30979

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1c6329
fix(material/sidenav): fix tabindex issue on side mode
DBowen33 Apr 29, 2025
51c1075
fix(material/sidenav): redo logic
DBowen33 May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/material/sidenav/drawer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ export class MatDrawerContent extends CdkScrollable implements AfterContentInit
'class': 'mat-drawer',
// must prevent the browser from aligning text based on value
'[attr.align]': 'null',
'[attr.tabindex]': '(!opened || mode === "side") ? null : -1',
'[class.mat-drawer-end]': 'position === "end"',
'[class.mat-drawer-over]': 'mode === "over"',
'[class.mat-drawer-push]': 'mode === "push"',
Expand All @@ -165,7 +166,6 @@ export class MatDrawerContent extends CdkScrollable implements AfterContentInit
// this was also done by the animations module which some internal tests seem to depend on.
// Simulate it by toggling the `hidden` attribute instead.
'[style.visibility]': '(!_container && !opened) ? "hidden" : null',
'tabIndex': '-1',
},
changeDetection: ChangeDetectionStrategy.OnPush,
encapsulation: ViewEncapsulation.None,
Expand Down
Loading