Skip to content

[Cherry pick] fix(multiple): ensure mat-option parents are the offsetParent #30980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

[Cherry pick] fix(multiple): ensure mat-option parents are the offsetParent #30980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/material/autocomplete/autocomplete.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,9 @@ div.mat-mdc-autocomplete-panel {
padding: 8px 0;
box-sizing: border-box;

// Workaround in case other MDC menu surface styles bleed in.
position: static;
// Necessary so the `offsetParent` of the nested `mat-option` is the
// panel which is required for scroll calculations (see #30974).
position: relative;

@include token-utils.use-tokens(
tokens-mat-autocomplete.$prefix, tokens-mat-autocomplete.get-token-slots()) {
Expand Down
9 changes: 3 additions & 6 deletions src/material/select/select.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,9 @@ div.mat-mdc-select-panel {
border-radius: 4px;
box-sizing: border-box;

// Workaround in case other MDC menu surface styles bleed in.
position: static;
// Necessary so the `offsetParent` of the nested `mat-option` is the
// panel which is required for scroll calculations (see #30974).
position: relative;

@include token-utils.use-tokens(
tokens-mat-select.$prefix, tokens-mat-select.get-token-slots()) {
Expand All @@ -188,10 +189,6 @@ div.mat-mdc-select-panel {
border-bottom-right-radius: 0;
transform-origin: bottom center;
}

.mat-mdc-option {
--mdc-list-list-item-container-color: var(--mat-select-panel-background-color);
}
}

.mat-select-panel-animations-enabled {
Expand Down
4 changes: 4 additions & 0 deletions src/material/timepicker/timepicker.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ mat-timepicker {
padding: 8px 0;
box-sizing: border-box;

// Necessary so the `offsetParent` of the nested `mat-option` is the
// panel which is required for scroll calculations (see #30974).
position: relative;

@include token-utils.use-tokens(
tokens-mat-timepicker.$prefix, tokens-mat-timepicker.get-token-slots()) {
@include token-utils.create-token-slot(border-bottom-left-radius, container-shape);
Expand Down
Loading