Skip to content

Conversation

devversion
Copy link
Member

@devversion devversion commented Apr 30, 2025

Leverages our new rules for architect, contributed by Aspect @alexeagle, for serving material.angular.io. This allows us to drop the architect-cli logic (which is more or less experimental / internal), and fixes an issue where sometimes TS diagnostics were not properly reported with architect standalone.

@devversion devversion requested a review from a team as a code owner April 30, 2025 11:21
@devversion devversion requested review from adolgachev and crisbeto and removed request for a team April 30, 2025 11:21
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Apr 30, 2025
@devversion devversion force-pushed the fix-docs-diagnostic branch from f08d04f to 4129ac9 Compare April 30, 2025 11:23
@devversion devversion force-pushed the fix-docs-diagnostic branch from 4129ac9 to c1f8ecb Compare April 30, 2025 11:24
@devversion devversion added the docs: preview When applied, a preview of the documentation site is deployed to Firebase label Apr 30, 2025
@devversion devversion force-pushed the fix-docs-diagnostic branch 2 times, most recently from 7d318a6 to b549fe4 Compare April 30, 2025 12:20
Leverages our new rules for architect, contributed by Aspect alexeagle
for serving material.angular.io. This allows us to drop the
architect-cli logic (which is more or less experimental / internal), and
fixes an issue where sometimes TS diagnostics were not properly reported
with architect standalone.
@devversion devversion force-pushed the fix-docs-diagnostic branch from b549fe4 to 0622153 Compare April 30, 2025 13:37
@devversion devversion requested a review from a team as a code owner April 30, 2025 13:37
Copy link

Deployed docs-preview for 0622153 to: https://ng-dev-previews-comp--pr-angular-components-30986-docs-3xmi9lri.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto removed the request for review from adolgachev April 30, 2025 14:35
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Apr 30, 2025
@crisbeto crisbeto merged commit e5ea9fe into angular:main Apr 30, 2025
29 of 31 checks passed
wildcardalice pushed a commit to wildcardalice/components that referenced this pull request May 12, 2025
Leverages our new rules for architect, contributed by Aspect alexeagle
for serving material.angular.io. This allows us to drop the
architect-cli logic (which is more or less experimental / internal), and
fixes an issue where sometimes TS diagnostics were not properly reported
with architect standalone.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project docs: preview When applied, a preview of the documentation site is deployed to Firebase target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants