feature for feat(MENU) #31014 #31026
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…="true", adding stay-open-while-press class to the element
hahaym6164
requested review from
andrewseguin and
crisbeto
and removed request for
a team
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue from : #31014
adding new feature for stay button pressed state when menu is opened.
I added a variable called _pressedWhileOpen default false, the setter will detect if it passed a true value. if [pressedWhileOpen]="true" this is detect on the trigger button for menu, the button will stay the pressd state when menu is opened.
This is my first time working on the open resource project, I did minimal change as I could.
When I checked the official document and I realized the is a place for contributors to work on like 'good first issure' or 'help wanted'. And I'm not sure if I'm allowed to directly work on this issue, but I saw this when I half done, so I finished it and create a pull request if i cannot get approved on this, it is totally fine.