Skip to content

Conversation

andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented May 7, 2025

Adds a migration to rename tokens:

  1. Switches from --mdc- prefixes to --mat-
  2. Switches around some component prefixes, like from --mat-tonal-button- to --mat-button-tonal (component goes first, then variant)
  3. Renames component names to match our terms, like from text-field to form-field

@andrewseguin andrewseguin force-pushed the rename-mdc-prefix-schematic branch 2 times, most recently from cb033c6 to b00eb3f Compare May 7, 2025 19:51
@andrewseguin andrewseguin force-pushed the rename-mdc-prefix-schematic branch from b00eb3f to c9db72a Compare May 8, 2025 12:35
@andrewseguin andrewseguin marked this pull request as ready for review May 8, 2025 12:51
@andrewseguin andrewseguin requested a review from a team as a code owner May 8, 2025 12:51
@andrewseguin andrewseguin requested review from crisbeto and wagnermaciel and removed request for a team May 8, 2025 12:51
{oldStr: '--mat-tab-header-with-background', newStr: '--mat-tab'},
{oldStr: '--mat-tab-indicator', newStr: '--mat-tab'},
{oldStr: '--mat-text-button', newStr: '--mat-button-text'},
{oldStr: '--mat-tonal-button', newStr: '--mat-button-tonal'},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bit deal, but I think we can skip the tonal button since it's new in v20.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah true...Ill leave it just for completeness but I think youre right

@andrewseguin andrewseguin added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate labels May 8, 2025
@andrewseguin andrewseguin merged commit 8af89be into angular:main May 8, 2025
27 of 28 checks passed
@andrewseguin
Copy link
Contributor Author

The changes were merged into the following branches: main, 20.0.x

andrewseguin added a commit that referenced this pull request May 8, 2025
* fix(material/schematics): add schematic to rename tokens

* fix(material/schematics): add schematic to rename tokens

* fix(material/schematics): fix rename tests

* fix(material/schematic): rename variables

---------

Co-authored-by: Andrew Seguin <[email protected]>
(cherry picked from commit 8af89be)
wildcardalice pushed a commit to wildcardalice/components that referenced this pull request May 12, 2025
* fix(material/schematics): add schematic to rename tokens

* fix(material/schematics): add schematic to rename tokens

* fix(material/schematics): fix rename tests

* fix(material/schematic): rename variables

---------

Co-authored-by: Andrew Seguin <[email protected]>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants