Skip to content

fix(material/schematics): token migration not replacing all instances #31277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2025
Merged

fix(material/schematics): token migration not replacing all instances #31277

merged 1 commit into from
Jun 3, 2025

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 3, 2025

Fixes that the v20 ng update migration was only replacing the first instance of tokens.

Fixes #31276.

@crisbeto
fix(material/schematics): token migration not replacing all instances
ecc8b05 
Fixes that the v20 `ng update` migration was only replacing the first instance of tokens.

Fixes angular#31276.
@crisbeto crisbeto requested a review from andrewseguin June 3, 2025 07:09
@crisbeto crisbeto requested a review from a team as a code owner June 3, 2025 07:09
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jun 3, 2025
@crisbeto crisbeto requested review from wagnermaciel and removed request for a team June 3, 2025 07:09
@crisbeto crisbeto removed the request for review from wagnermaciel June 3, 2025 12:24
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 3, 2025
@crisbeto crisbeto merged commit eba4719 into angular:main Jun 3, 2025
24 of 26 checks passed
@crisbeto
Copy link
Member Author

crisbeto commented Jun 3, 2025

The changes were merged into the following branches: main, 20.0.x

crisbeto added a commit that referenced this pull request Jun 3, 2025
@crisbeto
fix(material/schematics): token migration not replacing all instances (…
1af07e3 
…#31277)

Fixes that the v20 `ng update` migration was only replacing the first instance of tokens.

Fixes #31276.

(cherry picked from commit eba4719)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(migration): Broken Angular Material 20 CSS Variables Migration

2 participants

@crisbeto @andrewseguin