refactor: fix schematics not respecting new -module.ts suffix
#31299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
requested review from
adolgachev,
andrewseguin and
ok7sai
and removed request for
a team
andrewseguin
approved these changes
Jun 5, 2025
Angular CLI generates `-module.ts` suffix when using `--standalone: false`. Our schematic tests generate the same, and fail currently because some files weren't picked up properly by the rule. This commit fixes this, and adds supports for the new suffix in a naive way until angular/angular-cli#30471 is available.
devversion
force-pushed
the
fix-schematic-tests
branch
from
1277bce to
a48725f
Compare
devversion
added
action: merge
|
The changes were merged into the following branches: main, 20.0.x |
devversion
added a commit
that referenced
this pull request
Jun 5, 2025
Angular CLI generates `-module.ts` suffix when using `--standalone: false`. Our schematic tests generate the same, and fail currently because some files weren't picked up properly by the rule. This commit fixes this, and adds supports for the new suffix in a naive way until angular/angular-cli#30471 is available. (cherry picked from commit 394336c)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular CLI generates
-module.tssuffix when using--standalone: false. Our schematic tests generate the same, and fail currently because some files weren't picked up properly by the rule.This commit fixes this, and adds supports for the new suffix in a naive way until angular/angular-cli#30471 is available.