-
Notifications
You must be signed in to change notification settings - Fork 6.8k
docs(material/cdk/observers): Documentation supplement due to extended capabilities of the directive #31352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d capabilities of the directive
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@adolgachev @wagnermaciel сould you please consider my proposal? |
@crisbeto сould you please consider my proposal? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you! |
@crisbeto can you consider my proposal, please?) |
The changes were merged into the following branches: main, 20.1.x |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
When using the cdkObserveContent directive, I noticed that it reacts to changes in any content within the element it applies to, not just ng-content, or is this a coincidence?
If this is intended, I suggest improving the documentation so that this feature does not seem like a coincidence.
https://material.angular.dev/cdk/observers/overview
The suggested changes to the code could be edited better to convey the information more simply
Example:
When I click on the div in the console I see a message:
