fix(multiple): use inline m2 token definitions#31359
Merged
andrewseguin merged 1 commit intoangular:mainfrom Jun 16, 2025
Merged
fix(multiple): use inline m2 token definitions#31359andrewseguin merged 1 commit intoangular:mainfrom
andrewseguin merged 1 commit intoangular:mainfrom
Conversation
ea0ad82 to
501d977
Compare
501d977 to
191ab68
Compare
crisbeto
approved these changes
Jun 16, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defines M2 theme tokens (CSS vars) inline instead of creating a new selector block
Before, this would have split each component into its own html block:
With this change, these will be grouped together:
For some users, this will surface a Sass warning about mixed-decls. This was previously being avoided because the CSS created the variables in subsequent selector blocks, but are now inline.