Skip to content

compileComponents cleanups #31360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2025
Merged

compileComponents cleanups #31360

merged 2 commits into from
Jun 17, 2025

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 15, 2025

Fixes some calls to compileComponents that were introduced after the last cleanup. Also sets up tooling to prevent new ones from being added.

crisbeto added 2 commits June 15, 2025 09:50
@crisbeto
test(multiple): remove unnecessary compileComponents calls
18a1d61 
Removes some calls to `compileComponents` that aren't necessary.
@crisbeto
build: enforce compileComponents isn't called
907eca9 
Updates the lint rules not to allow calls to `compileComponents`.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jun 15, 2025
@crisbeto crisbeto requested a review from a team as a code owner June 15, 2025 07:53
@crisbeto crisbeto added the merge: preserve commits When the PR is merged, a rebase and merge should be performed label Jun 15, 2025
@crisbeto crisbeto requested review from andrewseguin and ok7sai and removed request for a team June 15, 2025 07:53
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Jun 15, 2025
@crisbeto crisbeto removed the request for review from andrewseguin June 17, 2025 16:23
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 17, 2025
@crisbeto crisbeto merged commit 4df402e into angular:main Jun 17, 2025
33 of 35 checks passed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jul 18, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

@ok7sai ok7sai ok7sai approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project merge: preserve commits When the PR is merged, a rebase and merge should be performed target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto @wagnermaciel @ok7sai