Skip to content

fix(material/core): improve disabled psuedo checkbox contrast #31464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025
Merged

fix(material/core): improve disabled psuedo checkbox contrast #31464

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c136fe
fix(material/core): improve disabled psuedo checkbox contrast
Jun 30, 2025
299f414
refactor: lint
andrewseguin Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions src/material/core/selection/pseudo-checkbox/_m2-pseudo-checkbox.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,6 @@

// Tokens that can be configured through Angular Material's color theming API.
@function private-get-color-palette-color-tokens($theme, $color-variant) {
// TODO: Use system colors instead of checking theme type
$is-dark: false;
@if (meta.type-of($theme) == map and map.get($theme, color)) {
$is-dark: inspection.get-theme-type($theme) == dark;
}
$disabled-color: if($is-dark, #686868, #b0b0b0);
$system: m2-utils.get-system($theme);
$system: m3-utils.replace-colors-with-variant($system, secondary, $color-variant);

Expand All @@ -29,9 +23,12 @@
pseudo-checkbox-full-selected-checkmark-color: map.get($system, background),
pseudo-checkbox-full-unselected-icon-color: map.get($system, on-surface-variant),
pseudo-checkbox-full-disabled-selected-checkmark-color: map.get($system, background),
pseudo-checkbox-full-disabled-unselected-icon-color: $disabled-color,
pseudo-checkbox-full-disabled-selected-icon-color: $disabled-color,
pseudo-checkbox-full-disabled-unselected-icon-color:
m3-utils.color-with-opacity(map.get($system, on-surface), 38%),
pseudo-checkbox-full-disabled-selected-icon-color:
m3-utils.color-with-opacity(map.get($system, on-surface), 38%),
pseudo-checkbox-minimal-selected-checkmark-color: map.get($system, secondary),
pseudo-checkbox-minimal-disabled-selected-checkmark-color: $disabled-color,
pseudo-checkbox-minimal-disabled-selected-checkmark-color:
m3-utils.color-with-opacity(map.get($system, on-surface), 38%),
);
}
Loading