-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Add an example of scrolling in CDK Drag and Drop #31528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
crisbeto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good, but the PR is missing a CLA and there are CI failures.
2b42f48 to
4ae187c
Compare
|
I think I fixed them. It should be good now. |
|
@mmalerba Did I mess something up?
I dont remember adding tests. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |

This is to fix the issue that many people miss that you need an extra bit for scrolling to work with the CDK drag and drop.
#31519, #29161, and maybe this one #24553. There were a few others, but I cant find them now.
This adds documentation that shows you need to include the
CdkScrollableotherwise scrolling wont work.