Skip to content

fix(material/slider): tick marks not showing dynamically #31608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2025
Merged

fix(material/slider): tick marks not showing dynamically #31608

merged 1 commit into from
Jul 29, 2025

Conversation

crisbeto
Copy link
Member

Fixes that if showTickMarks is false initially and then switches to true, the slider wasn't updating to show the tick marks.

Fixes #31590.

@crisbeto
fix(material/slider): tick marks not showing dynamically
965cd94 
Fixes that if `showTickMarks` is `false` initially and then switches to `true`, the slider wasn't updating to show the tick marks.

Fixes angular#31590.
@crisbeto crisbeto requested a review from a team as a code owner July 28, 2025 11:47
@crisbeto crisbeto removed the request for review from a team July 28, 2025 11:47
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jul 28, 2025
wagnermaciel
wagnermaciel approved these changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto removed the request for review from andrewseguin July 29, 2025 04:42
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 29, 2025
@crisbeto crisbeto merged commit 9e14c55 into angular:main Jul 29, 2025
34 of 37 checks passed
@crisbeto
Copy link
Member Author

The changes were merged into the following branches: main, 20.1.x

crisbeto added a commit that referenced this pull request Jul 29, 2025
@crisbeto
fix(material/slider): tick marks not showing dynamically (#31608)
4ae4fe2 
Fixes that if `showTickMarks` is `false` initially and then switches to `true`, the slider wasn't updating to show the tick marks.

Fixes #31590.

(cherry picked from commit 9e14c55)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: material/slider target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(Mat-Slider): showTickMarks not displaying tick marks

2 participants

@crisbeto @wagnermaciel