Skip to content

Conversation

adolgachev
Copy link
Contributor

@adolgachev adolgachev commented Aug 5, 2025

Fixes (or at least first step in fixing) b/286287327 where ripple shows static chips as being interactive even when they are not.

@adolgachev adolgachev changed the title Chips static fix(material/chips): static chips should disable ripple Aug 5, 2025
@adolgachev adolgachev added Accessibility This issue is related to accessibility (a11y) target: minor This PR is targeted for the next minor release action: global presubmit The PR is in need of a google3 global presubmit dev-app preview When applied, previews of the dev-app are deployed to Firebase labels Aug 5, 2025
Copy link

github-actions bot commented Aug 5, 2025

Deployed dev-app for 933f678 to: https://ng-dev-previews-comp--pr-angular-components-31652-dev-fvg342zv.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@adolgachev adolgachev added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: global presubmit The PR is in need of a google3 global presubmit labels Aug 6, 2025
@adolgachev adolgachev marked this pull request as ready for review August 6, 2025 16:38
@adolgachev adolgachev requested a review from a team as a code owner August 6, 2025 16:38
@adolgachev adolgachev requested review from andrewseguin and mmalerba and removed request for a team August 6, 2025 16:38
@adolgachev adolgachev added the docs: preview When applied, a preview of the documentation site is deployed to Firebase label Aug 6, 2025
Copy link

github-actions bot commented Aug 6, 2025

Deployed docs-preview for 933f678 to: https://ng-dev-previews-comp--pr-angular-components-31652-docs-3rv41liy.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@adolgachev adolgachev removed the request for review from mmalerba August 7, 2025 17:29
@adolgachev adolgachev added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 7, 2025
@adolgachev adolgachev merged commit 37648cf into angular:main Aug 7, 2025
29 of 32 checks passed
@adolgachev adolgachev deleted the chips-static branch August 7, 2025 17:37
demanr pushed a commit to demanr/components that referenced this pull request Aug 7, 2025
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: material/chips dev-app preview When applied, previews of the dev-app are deployed to Firebase docs: preview When applied, a preview of the documentation site is deployed to Firebase target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants