docs: insert canonical link dynamically #31830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesmiler
requested review from
JeanMeche,
crisbeto and
ok7sai
and removed request for
a team
JeanMeche
approved these changes
Sep 5, 2025
crisbeto
reviewed
Sep 6, 2025
| canonicalLink.setAttribute('rel', 'canonical'); | ||
| canonicalLink.setAttribute('href', fullPath); | ||
|
|
||
| const title = this._document.head.querySelector('title'); |
There was a problem hiding this comment.
This seems a bit convoluted. We can just do document.head.appendChild(canonicalLink).
There was a problem hiding this comment.
I had that first but then thought that the search engine might not process the canonical (with the same priority) if it's at the very end of the long even below the long <script> tag. But given that this would be only for a search engine that runs JS - this is probably silly.
crisbeto
pushed a commit
to crisbeto/material2
that referenced
this pull request
Sep 8, 2025
* docs: delete static canonical link * docs: insert, not update dynamic canonical link * docs: always append tag when inserted
adolgachev
pushed a commit
that referenced
this pull request
Sep 8, 2025
* docs: delete static canonical link * docs: insert, not update dynamic canonical link * docs: always append tag when inserted
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past we had a static canonical link to material.angular.dev/ for all pages that got dynamically updated to the correct URL.
However Search engines sometimes don't seem to parse the JS and in this case having the canonical point to material.angular.dev/ seems worse than having it not present as it prevents pages from being indexed.