Skip to content

Conversation

adolgachev
Copy link
Contributor

@adolgachev adolgachev commented Sep 30, 2025

Fixes b/447648716 by tweaking html and aria attributes to remove on extra announcement with voice over, and amend other one.

Hide the select label from aria as already used for the labelel-by so it does not read off as two annoucements (one with group appended)

Add role of status to the live annouce of the page count, so it will still read a second time but at least will announce correctly as a status message instead of just generic group.

There are a lot of similar issues with divs causing extra announcements with VO. This at least mitigates a little and makes it make more sense.

@adolgachev adolgachev added Accessibility This issue is related to accessibility (a11y) target: minor This PR is targeted for the next minor release dev-app preview When applied, previews of the dev-app are deployed to Firebase action: review The PR is still awaiting reviews from at least one requested reviewer action: global presubmit The PR is in need of a google3 global presubmit requires: TGP This PR requires a passing TGP before merging is allowed labels Sep 30, 2025
Copy link

github-actions bot commented Sep 30, 2025

Deployed dev-app for 3409602 to: https://ng-dev-previews-comp--pr-angular-components-31943-dev-ntdpsf6k.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@adolgachev adolgachev marked this pull request as ready for review September 30, 2025 19:28
@adolgachev adolgachev requested a review from a team as a code owner September 30, 2025 19:28
@adolgachev adolgachev requested review from mmalerba and wagnermaciel and removed request for a team September 30, 2025 19:28
@adolgachev adolgachev added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: global presubmit The PR is in need of a google3 global presubmit labels Oct 1, 2025
@adolgachev adolgachev removed the request for review from wagnermaciel October 1, 2025 19:18
@adolgachev adolgachev merged commit 131c7ff into angular:main Oct 1, 2025
24 of 26 checks passed
@adolgachev adolgachev deleted the paginator branch October 1, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: material/paginator dev-app preview When applied, previews of the dev-app are deployed to Firebase requires: TGP This PR requires a passing TGP before merging is allowed target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants