fix(material/datepicker): error due to synchronous change detection #31970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The month view had a `detectChanges` call that was happening inside a `blur` event which ended up causing re-entrant change detection and hitting an assertion in the framework. These changes remove it since it doesn't appear to be necessary anymore. Fixes angular#31959.
…nals Converts some of the internal calendar state to signals to test the waters on how breaking it would be.
crisbeto
requested review from
adolgachev and
tjshiu
and removed request for
a team
crisbeto
commented
Oct 2, 2025
| // the way `_focusActiveCell` is set up at the moment makes it fire at the wrong time | ||
| // when navigating one month back using the keyboard which will cause this handler | ||
| // to throw a "changed after checked" error when updating the preview state. | ||
| this._changeDetectorRef.detectChanges(); |
There was a problem hiding this comment.
Deleting this line is the fix for #31959.
crisbeto
added
the
merge: preserve commits
andrewseguin
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The month view had a
detectChangescall that was happening inside ablurevent which ended up causing re-entrant change detection and hitting an assertion in the framework. These changes remove it since it doesn't appear to be necessary anymore.Fixes #31959.
I've also converted the internal calendar state to signals to get a feel for how breaking something like this might be.