-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(material/timepicker): add option template #32014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lekhmanrus
wants to merge
2
commits into
angular:main
Choose a base branch
from
lekhmanrus:feat/31209/add-option-template_
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+109
−5
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
...es/material/timepicker/timepicker-option-template/timepicker-option-template-example.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
<mat-form-field> | ||
<mat-label>Pick a time</mat-label> | ||
<input matInput [matTimepicker]="picker"> | ||
<mat-timepicker-toggle matIconSuffix [for]="picker"/> | ||
<mat-timepicker #picker> | ||
<ng-template let-option> | ||
<mat-icon> | ||
{{ (dateAdapter.compareTime(option.value, sunrise) > 0 && dateAdapter.compareTime(option.value, sunset) < 0) ? 'sunny' : 'bedtime' }} | ||
</mat-icon> | ||
{{ option.label }} | ||
</ng-template> | ||
</mat-timepicker> | ||
</mat-form-field> |
27 changes: 27 additions & 0 deletions
27
...ples/material/timepicker/timepicker-option-template/timepicker-option-template-example.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import {ChangeDetectionStrategy, Component, inject} from '@angular/core'; | ||
import {MatTimepickerModule} from '@angular/material/timepicker'; | ||
import {MatIcon} from '@angular/material/icon'; | ||
import {MatInputModule} from '@angular/material/input'; | ||
import {MatFormFieldModule} from '@angular/material/form-field'; | ||
import {DateAdapter, provideNativeDateAdapter} from '@angular/material/core'; | ||
|
||
/** @title Timepicker with option template. */ | ||
@Component({ | ||
selector: 'timepicker-option-template-example', | ||
templateUrl: 'timepicker-option-template-example.html', | ||
providers: [provideNativeDateAdapter()], | ||
imports: [MatFormFieldModule, MatIcon, MatInputModule, MatTimepickerModule], | ||
changeDetection: ChangeDetectionStrategy.OnPush, | ||
}) | ||
export class TimepickerOptionTemplateExample { | ||
readonly dateAdapter = inject<DateAdapter<Date>>(DateAdapter); | ||
readonly sunrise: Date; | ||
readonly sunset: Date; | ||
|
||
constructor() { | ||
this.sunrise = new Date(); | ||
this.sunrise.setHours(7, 0, 0); | ||
this.sunset = new Date(); | ||
this.sunset.setHours(17, 30, 0); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,7 @@ import { | |
ChangeDetectionStrategy, | ||
Component, | ||
computed, | ||
contentChild, | ||
effect, | ||
ElementRef, | ||
inject, | ||
|
@@ -33,6 +34,7 @@ import { | |
ViewContainerRef, | ||
ViewEncapsulation, | ||
} from '@angular/core'; | ||
import {NgTemplateOutlet} from '@angular/common'; | ||
import { | ||
_animationsDisabled, | ||
DateAdapter, | ||
|
@@ -92,7 +94,7 @@ export const MAT_TIMEPICKER_SCROLL_STRATEGY = new InjectionToken<() => ScrollStr | |
styleUrl: 'timepicker.css', | ||
changeDetection: ChangeDetectionStrategy.OnPush, | ||
encapsulation: ViewEncapsulation.None, | ||
imports: [MatOption], | ||
imports: [NgTemplateOutlet, MatOption], | ||
providers: [ | ||
{ | ||
provide: MAT_OPTION_PARENT_COMPONENT, | ||
|
@@ -123,6 +125,7 @@ export class MatTimepicker<D> implements OnDestroy, MatOptionParentComponent { | |
protected _panelTemplate = viewChild.required<TemplateRef<unknown>>('panelTemplate'); | ||
protected _timeOptions: readonly MatTimepickerOption<D>[] = []; | ||
protected _options = viewChildren(MatOption); | ||
protected _optionTemplate = contentChild<TemplateRef<MatTimepickerOption<D>>>(TemplateRef); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually I think we may have to provide this through an input or have a directive that users apply on the |
||
|
||
private _keyManager = new ActiveDescendantKeyManager(this._options, this._injector) | ||
.withHomeAndEnd(true) | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.